Emulate blob storage latency in benchmarks #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
changed the title
Contributor
|
Can you make this configurable latency? And any ideas on how to do throughput? |
Contributor
Author
|
I'll add throughput in a second, I need to think for a bit about how to make the latency configurable in a useful way. |
Contributor
|
I guess throughput is adding some extra latency proportional to size? |
gatesn
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nvme devices we use for benchmarks (both in the cloud and locally) are incredibly fast and have incredibly low latency, which makes them forgiving in exactly the way real object storage isnt.
This is an attempt at allowing us to emulate the performance of real cloud system in a more reproducible way, the constants and distributions are not set in stone and we can defiantly change them around, especially for ranged read where we have more specific numbers from AnyBlob.